linux-kernel - Re: [PATCH] perf script: Remove unnecessary conversion to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 Nov 2020 13:29:55 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     xiakaixu1987@...il.com
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [PATCH] perf script: Remove unnecessary conversion to bool

Hello,

On Fri, Nov 6, 2020 at 12:33 PM <xiakaixu1987@...il.com> wrote:
>
> From: Kaixu Xia <kaixuxia@...cent.com>
>
> Here we could use the '!=' expression to fix the following coccicheck
> warning:
>
> ./tools/perf/builtin-script.c:3209:48-53: WARNING: conversion to bool not needed here
> ./tools/perf/builtin-script.c:2761:36-41: WARNING: conversion to bool not needed here
>
> Reported-by: Tosk Robot <tencent_os_robot@...cent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung


> ---
>  tools/perf/builtin-script.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 48588ccf902e..b5a6fd63ca5f 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -2758,7 +2758,7 @@ static int parse_output_fields(const struct option *opt __maybe_unused,
>                                 break;
>                 }
>                 if (i == imax && strcmp(tok, "flags") == 0) {
> -                       print_flags = change == REMOVE ? false : true;
> +                       print_flags = change != REMOVE;
>                         continue;
>                 }
>                 if (i == imax) {
> @@ -3206,7 +3206,7 @@ static char *get_script_path(const char *script_root, const char *suffix)
>
>  static bool is_top_script(const char *script_path)
>  {
> -       return ends_with(script_path, "top") == NULL ? false : true;
> +       return ends_with(script_path, "top") != NULL;
>  }
>
>  static int has_required_arg(char *script_path)
> --
> 2.20.0
>