[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <15cc973a481dea85081c4466b18df6a3e0cb280f.camel@gmail.com>
Date: Fri, 06 Nov 2020 06:57:49 +0100
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: Wang Qing <wangqing@...o.com>,
Hartley Sweeten <hsweeten@...ionengravers.com>,
Russell King <linux@...linux.org.uk>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: Add clk_get_rate input parameter null check
Hello Wang!
On Fri, 2020-11-06 at 09:46 +0800, Wang Qing wrote:
> The input parameter of clk_get_rate() is checked with IS_ERR(),
> so here we need to check null on clk.
Thank you for the patch!
> Signed-off-by: Wang Qing <wangqing@...o.com>
Acked-by: Alexander Sverdlin <alexander.sverdlin@...il.com>
> ---
> arch/arm/mach-ep93xx/clock.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mach-ep93xx/clock.c b/arch/arm/mach-
> ep93xx/clock.c
> index 2810eb5..4313b2f
> --- a/arch/arm/mach-ep93xx/clock.c
> +++ b/arch/arm/mach-ep93xx/clock.c
> @@ -321,6 +321,9 @@ static unsigned long get_uart_rate(struct clk
> *clk)
>
> unsigned long clk_get_rate(struct clk *clk)
> {
> + if (!clk)
> + return 0;
> +
> if (clk->get_rate)
> return clk->get_rate(clk);
>
--
Alexander Sverdlin.
Powered by blists - more mailing lists