linux-kernel - Re: [PATCH] arm64: dts: exynos: Use fixed index for the MMC devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <119c90b2-7157-ed07-5ef2-ec64d98c8823@samsung.com>
Date:   Fri, 6 Nov 2020 15:00:54 +0900
From:   Jaehoon Chung <jh80.chung@...sung.com>
To:     Marek Szyprowski <m.szyprowski@...sung.com>,
        linux-samsung-soc@...r.kernel.org
Cc:     Krzysztof Kozlowski <krzk@...nel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Markus Reichl <m.reichl@...etechno.de>,
        Rob Herring <robh+dt@...nel.org>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: exynos: Use fixed index for the MMC devices

On 11/5/20 8:48 PM, Marek Szyprowski wrote:
> Recently introduced asynchronous probe on the MMC devices can shuffle
> block IDs in the system. Pin them to values equal to the physical MMC bus
> number to ease booting in environments where UUIDs are not practical.
> 
> Use newly introduced aliases for mmcblk devices from commit fa2d0aa96941
> ("mmc: core: Allow setting slot index via device tree alias").
> 
> Suggested-by: Markus Reichl <m.reichl@...etechno.de>
> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>


Reviewed-by: Jaehoon Chung <jh80.chung@...sung.com>

Best Regards,
Jaehoon Chung

> ---
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 ++++++
>  arch/arm64/boot/dts/exynos/exynos7.dtsi    | 3 +++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 0a886bb6c806..3a37ad97fcdb 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -23,6 +23,12 @@
>  
>  	interrupt-parent = <&gic>;
>  
> +	aliases {
> +		mmc0 = &mshc_0;
> +		mmc1 = &mshc_1;
> +		mmc2 = &mshc_2;
> +	};
> +
>  	arm_a53_pmu {
>  		compatible = "arm,cortex-a53-pmu";
>  		interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> index 48cd3a04fd07..3e319ec64997 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> @@ -16,6 +16,9 @@
>  	#size-cells = <2>;
>  
>  	aliases {
> +		mmc0 = &mmc_0;
> +		mmc1 = &mmc_1;
> +		mmc2 = &mmc_2;
>  		pinctrl0 = &pinctrl_alive;
>  		pinctrl1 = &pinctrl_bus0;
>  		pinctrl2 = &pinctrl_nfc;
>