linux-kernel - Re: [PATCH] usb: Assign NULL to phy that may be returned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201106065131.GD697514@kroah.com>
Date:   Fri, 6 Nov 2020 07:51:31 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Wang Qing <wangqing@...o.com>
Cc:     Felipe Balbi <balbi@...nel.org>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: Assign NULL to
 phy that may be returned

On Fri, Nov 06, 2020 at 11:15:55AM +0800, Wang Qing wrote:
> Assign initial values to local variables that may be returned
> 
> Signed-off-by: Wang Qing <wangqing@...o.com>

Your subject, and body of text, seem to have 2 "odd" characters in it,
please fix up.

Also, your subject and changelog body here are identical, please be much
more verbose in the body explaining why you are doing something, not
just what you are doing.

And your subject line should also match other patches for this file, and
have "usb: phy: ..." in the beginning.

> ---
>  drivers/usb/phy/phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c
> index b47285f..de21967
> --- a/drivers/usb/phy/phy.c
> +++ b/drivers/usb/phy/phy.c
> @@ -59,7 +59,7 @@ static struct usb_phy *__usb_find_phy(struct list_head *list,
>  
>  static struct usb_phy *__of_usb_find_phy(struct device_node *node)
>  {
> -	struct usb_phy  *phy;
> +	struct usb_phy  *phy = NULL;

Why isn't the compiler complaining about this today?  Are you sure this
is needed?

thanks,

greg k-h