linux-kernel - Re: [PATCH] riscv: uaccess: fix __put_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-21386a65-a083-4346-89a7-0b8ac583b9c4@palmerdabbelt-glaptop1>
Date:   Thu, 05 Nov 2020 23:45:03 -0800 (PST)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     changbin.du@...il.com
CC:     Paul Walmsley <paul.walmsley@...ive.com>, aou@...s.berkeley.edu,
        akpm@...ux-foundation.org, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, changbin.du@...il.com,
        Christoph Hellwig <hch@....de>
Subject:     Re: [PATCH] riscv: uaccess: fix __put_kernel_nofault()

On Sun, 01 Nov 2020 23:30:52 PST (-0800), changbin.du@...il.com wrote:
> The copy_from_kernel_nofault() is broken on riscv because the 'dst' and
> 'src' are mistakenly reversed in __put_kernel_nofault() macro.
>
> copy_to_kernel_nofault:
> ...
> 0xffffffe0003159b8 <+30>:    sd      a4,0(a1) # a1 aka 'src'
>
> Fixes: d464118cdc ("riscv: implement __get_kernel_nofault and __put_user_nofault")
> Signed-off-by: Changbin Du <changbin.du@...il.com>
> Cc: Christoph Hellwig <hch@....de>
> ---
>  arch/riscv/include/asm/uaccess.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/include/asm/uaccess.h b/arch/riscv/include/asm/uaccess.h
> index c47e6b35c551..824b2c9da75b 100644
> --- a/arch/riscv/include/asm/uaccess.h
> +++ b/arch/riscv/include/asm/uaccess.h
> @@ -476,7 +476,7 @@ do {									\
>  do {									\
>  	long __kr_err;							\
>  									\
> -	__put_user_nocheck(*((type *)(dst)), (type *)(src), __kr_err);	\
> +	__put_user_nocheck(*((type *)(src)), (type *)(dst), __kr_err);	\
>  	if (unlikely(__kr_err))						\
>  		goto err_label;						\
>  } while (0)

Thanks, this is on fixes.