linux-kernel - Re: [PATCH 25/36] tty: serial: sifive: Struct headers should start with 'struct <name>'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-ddfc93f8-d5a0-4f6c-99be-db3c62cc3c24@palmerdabbelt-glaptop1>
Date:   Fri, 06 Nov 2020 00:11:51 -0800 (PST)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     lee.jones@...aro.org
CC:     lee.jones@...aro.org, linux-kernel@...r.kernel.org,
        Greg KH <gregkh@...uxfoundation.org>, jirislaby@...nel.org,
        Paul Walmsley <paul.walmsley@...ive.com>,
        linux-serial@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject:     Re: [PATCH 25/36] tty: serial: sifive: Struct headers should start with 'struct <name>'

On Wed, 04 Nov 2020 11:35:38 PST (-0800), lee.jones@...aro.org wrote:
> Also supply a missing member description.
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/tty/serial/sifive.c:157: warning: cannot understand function prototype: 'struct sifive_serial_port '
>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Jiri Slaby <jirislaby@...nel.org>
> Cc: Palmer Dabbelt <palmer@...belt.com>
> Cc: Paul Walmsley <paul.walmsley@...ive.com>
> Cc: linux-serial@...r.kernel.org
> Cc: linux-riscv@...ts.infradead.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/tty/serial/sifive.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c
> index 13eadcb8aec4e..1066eebe3b28b 100644
> --- a/drivers/tty/serial/sifive.c
> +++ b/drivers/tty/serial/sifive.c
> @@ -144,12 +144,13 @@
>   */
>
>  /**
> - * sifive_serial_port - driver-specific data extension to struct uart_port
> + * struct sifive_serial_port - driver-specific data extension to struct uart_port
>   * @port: struct uart_port embedded in this struct
>   * @dev: struct device *
>   * @ier: shadowed copy of the interrupt enable register
>   * @clkin_rate: input clock to the UART IP block.
>   * @baud_rate: UART serial line rate (e.g., 115200 baud)
> + * @clk: reference to this device's clock
>   * @clk_notifier: clock rate change notifier for upstream clock changes
>   *
>   * Configuration data specific to this SiFive UART.

Reviewed-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
Acked-by: Palmer Dabbelt <palmerdabbelt@...gle.com>

Thanks!