linux-kernel - Re: [PATCH v2] tracing: Add register read and write tracing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201106090916.GB9496@willie-the-truck>
Date:   Fri, 6 Nov 2020 09:09:17 +0000
From:   Will Deacon <will@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Prasad Sodagudi <psodagud@...eaurora.org>, rostedt@...dmis.org,
        mingo@...hat.com, keescook@...omium.org, catalin.marinas@....com,
        saiprakash.ranjan@...eaurora.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, anton@...msg.org, arnd@...db.de,
        ccross@...roid.com, jbaron@...mai.com, jim.cromie@...il.com,
        joe@...ches.com, joel@...lfernandes.org
Subject: Re: [PATCH v2] tracing: Add register read and write tracing support

On Fri, Nov 06, 2020 at 07:49:29AM +0100, Greg KH wrote:
> On Thu, Nov 05, 2020 at 06:56:26PM -0800, Prasad Sodagudi wrote:
> > Add register read/write operations tracing support.
> > ftrace events helps to trace register read and write
> > location details of memory mapped IO registers.
> 
> This sentance does not parse for me, can you please rework it?
> 
> > These trace logs helps to debug un clocked access
> > of peripherals.
> 
> "un clocked"?  What does that mean?
> 
> And you do have 72 columns to fill, please use it :)
> 
> > 
> > Signed-off-by: Prasad Sodagudi <psodagud@...eaurora.org>
> > ---
> >  arch/arm64/include/asm/io.h    |  9 ++++++++
> >  arch/arm64/kernel/image-vars.h |  8 +++++++
> 
> You are only adding it for arm64, why not add the generic support first,
> and then add it for all "major" arches afterwards?

Yeah, or just hook the higher-level accessors rather than the arch-specific
bowels. Less work for more coverage that way!

Will