[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VdHuZc43Oe8vp-Xtb2+vsEoV2FY-W_dAifuh4Un0BveSA@mail.gmail.com>
Date: Fri, 6 Nov 2020 11:24:47 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Greentime Hu <greentime.hu@...ive.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <bgolaszewski@...libre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
linux-riscv@...ts.infradead.org,
Palmer Dabbelt <palmer@...belt.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Yash Shah <yash.shah@...ive.com>
Subject: Re: [RFC PATCH 1/1] gpio: sifive: To get gpio irq offset from device
tree data
On Fri, Nov 6, 2020 at 4:59 AM Greentime Hu <greentime.hu@...ive.com> wrote:
>
> We can get hwirq number of the gpio by its irq_data->hwirq so that we don't
> need to add more macros for different platforms. This patch is tested in
> SiFive Unleashed board and SiFive Unmatched board.
...
> + struct sifive_gpio *chip = gpiochip_get_data(gc);
> + struct irq_data *d = irq_get_irq_data(chip->irq_number[child]);
> + *parent = d->hwirq;
There is an API to get hwirq.
...
> + for (i = 0; i < ngpio; i++)
> + chip->irq_number[i] = irq_of_parse_and_map(node, i);
Can't you use platform_get_irq_optional()?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists