linux-kernel - Re: [PATCH] x86/kvm: remove unused macro HV_CLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o8ka3k0b.fsf@vitty.brq.redhat.com>
Date:   Fri, 06 Nov 2020 10:35:48 +0100
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        hpa@...or.com
Subject: Re: [PATCH] x86/kvm: remove unused macro HV_CLOCK_SIZE

Alex Shi <alex.shi@...ux.alibaba.com> writes:

> This macro is useless, and could cause gcc warning:
> arch/x86/kernel/kvmclock.c:47:0: warning: macro "HV_CLOCK_SIZE" is not
> used [-Wunused-macros]
> Let's remove it.
>
> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Cc: Paolo Bonzini <pbonzini@...hat.com> 
> Cc: Sean Christopherson <sean.j.christopherson@...el.com> 
> Cc: Vitaly Kuznetsov <vkuznets@...hat.com> 
> Cc: Wanpeng Li <wanpengli@...cent.com> 
> Cc: Jim Mattson <jmattson@...gle.com> 
> Cc: Joerg Roedel <joro@...tes.org> 
> Cc: Thomas Gleixner <tglx@...utronix.de> 
> Cc: Ingo Molnar <mingo@...hat.com> 
> Cc: Borislav Petkov <bp@...en8.de> 
> Cc: x86@...nel.org 
> Cc: "H. Peter Anvin" <hpa@...or.com> 
> Cc: kvm@...r.kernel.org 
> Cc: linux-kernel@...r.kernel.org 
> ---
>  arch/x86/kernel/kvmclock.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
> index 34b18f6eeb2c..aa593743acf6 100644
> --- a/arch/x86/kernel/kvmclock.c
> +++ b/arch/x86/kernel/kvmclock.c
> @@ -44,7 +44,6 @@ static int __init parse_no_kvmclock_vsyscall(char *arg)
>  early_param("no-kvmclock-vsyscall", parse_no_kvmclock_vsyscall);
>  
>  /* Aligned to page sizes to match whats mapped via vsyscalls to userspace */
> -#define HV_CLOCK_SIZE	(sizeof(struct pvclock_vsyscall_time_info) * NR_CPUS)
>  #define HVC_BOOT_ARRAY_SIZE \
>  	(PAGE_SIZE / sizeof(struct pvclock_vsyscall_time_info))

Fixes: 95a3d4454bb1 ("x86/kvmclock: Switch kvmclock data to a PER_CPU variable")

where the last and the only user was removed.

Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com>

-- 
Vitaly