linux-kernel - Re: [PATCH 6/6] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201106094533.GB823981@google.com>
Date:   Fri, 6 Nov 2020 01:45:33 -0800
From:   Prashant Malani <pmalani@...omium.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, heikki.krogerus@...ux.intel.com,
        dzigterman@...omium.org, alevkoy@...omium.org,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH 6/6] platform/chrome: cros_ec_typec: Store cable plug type

Hi Greg,

On Fri, Nov 06, 2020 at 10:33:02AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Nov 06, 2020 at 12:59:07AM -0800, Prashant Malani wrote:
> > Hi Greg,
> > 
> > Did you not receive these?
> 
> Ah, I got 1, 2, and 5, and now 6.  That's confusing, think about if you
> were to receive such a series, what would you think to do with it?
> 

Yeah, I agree it looks confusing. Sorry about that.

> > > So you save it but what happens with the value?
> > 
> > The type C connector class framework exposes it via syfs to user-space when we
> > register the cable via typec_register_cable() in patch 4/6 [2].
> 
> So you added a new sysfs file and api without updating
> Documentation/ABI/?  That's not good :(

This is a pre-existing API[1] and sysfs file[2] so we are using those
and not adding anything new.

[1]:
https://www.kernel.org/doc/html/latest/driver-api/usb/typec.html#c.typec_register_cable
[2]: https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-class-typec
(see /sys/class/<port>-cable/plug_type)


Best regards,