linux-kernel - Re: [PATCH v13 06/14] KVM: Make dirty ring exclusive to dirty bitmap log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26c461bc-b2e3-bc23-fff6-0377b09d325a@redhat.com>
Date:   Fri, 6 Nov 2020 12:00:41 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Peter Xu <peterx@...hat.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Sean Christopherson <sean.j.christopherson@...el.com>,
        "Dr . David Alan Gilbert" <dgilbert@...hat.com>,
        Andrew Jones <drjones@...hat.com>
Subject: Re: [PATCH v13 06/14] KVM: Make dirty ring exclusive to dirty bitmap
 log

On 01/10/20 03:22, Peter Xu wrote:
>   
> +	/* Dirty ring tracking is exclusive to dirty log tracking */
> +	if (kvm->dirty_ring_size)
> +		return -EINVAL;
> +

ENXIO is slightly more appropriate (especially for debugging, as EINVAL 
suggests that the arguments were wrong and not some external state).

Paolo