linux-kernel - Re: [PATCH] x86/kexec: Initialize the value of ident mapping offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 Nov 2020 16:22:44 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Hewenliang <hewenliang4@...wei.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        osandov@...com, rppt@...nel.org, lijiang@...hat.com,
        linux-kernel@...r.kernel.org, hushiyuan@...wei.com
Subject: Re: [PATCH] x86/kexec: Initialize the value of ident mapping offset

On Thu, Nov 05, 2020 at 10:30:05PM -0500, Hewenliang wrote:
> From: hewenliang <hewenliang4@...wei.com>
> 
> It is necessary to initialize the value of ident mapping offset.

Why is it necessary?

> This can not only avoid using dirty data,

What happens to designated initializers when some of the members are not
explicitly mentioned?

Hint:

$ make arch/x86/kernel/machine_kexec_64.s

and look at that file before your patch.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette