linux-kernel - [PATCH] proc: fix comparison to bool warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1604763011-7972-1-git-send-email-kaixuxia@tencent.com>
Date:   Sat,  7 Nov 2020 23:30:11 +0800
From:   xiakaixu1987@...il.com
To:     adobriyan@...il.com
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kaixu Xia <kaixuxia@...cent.com>
Subject: [PATCH] proc: fix comparison to bool warning

From: Kaixu Xia <kaixuxia@...cent.com>

Fix the following coccicheck warning:

./fs/proc/generic.c:370:5-31: WARNING: Comparison to bool

Reported-by: Tosk Robot <tencent_os_robot@...cent.com>
Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>
---
 fs/proc/generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index 2f9fa179194d..4533eb826af7 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -367,7 +367,7 @@ struct proc_dir_entry *proc_register(struct proc_dir_entry *dir,
 
 	write_lock(&proc_subdir_lock);
 	dp->parent = dir;
-	if (pde_subdir_insert(dir, dp) == false) {
+	if (!pde_subdir_insert(dir, dp)) {
 		WARN(1, "proc_dir_entry '%s/%s' already registered\n",
 		     dir->name, dp->name);
 		write_unlock(&proc_subdir_lock);
-- 
2.20.0