linux-kernel - Re: [PATCH] ALSA: usb-audio: Fix coding style problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 8 Nov 2020 16:49:46 +0530
From:   Atul Gopinathan <leoatul12@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     perex@...ex.cz, tiwai@...e.com, linux-kernel@...r.kernel.org,
        alsa-devel@...a-project.org
Subject: Re: [PATCH] ALSA: usb-audio: Fix coding style problems

On Sun, Nov 08, 2020 at 10:11:36AM +0100, Greg KH wrote:
> On Sun, Nov 08, 2020 at 02:05:16PM +0530, Atul wrote:
> > From: Atul Gopinathan <leoatul12@...il.com>
> > 
> > Hi,
> 
> No need for this to be in the changelog.
> 
> > 
> > This patch fixes some coding style warnings and errors that were
> > generated using scripts/checkpatch.pl.
> 
> You should be explicit about _what_ warnings and errors.  And probably
> break them out into individual patches, one per warning/error type.
> 

Got it, I'll keep the above points in mind.

> But more importantly, always run your patch through checkpatch.pl when
> you are done, as you just _ADDED_ warnings to the kernel with this
> change:
> 
> > @@ -895,9 +896,10 @@ static int snd_usb_nativeinstruments_boot_quirk(struct usb_device *dev)
> >  	usb_reset_device(dev);
> >  
> >  	/* return -EAGAIN, so the creation of an audio interface for this
> > -	 * temporary device is aborted. The device will reconnect with a
> > -	 * new product ID */
> > -	return -EAGAIN;
> > +     * temporary device is aborted. The device will reconnect with a
> > +     * new product ID
> > +     */
> > +    return -EAGAIN;
> >  }
> >  
> >  static void mbox2_setup_48_24_magic(struct usb_device *dev)
> 
> You turned tabs into spaces, not allowed, sorry.

I truly apologize for this blunder. That was a really silly mistake from
my side inspite of having seen your FOSDEM talk on 'Submitting Your First
Kernel Patch' and using indentations as they were intended to be a
hundred times.

> 
> If you want to do basic checkpatch cleanups, try starting in the
> drivers/staging/ area of the kernel, which is much more forgiving and
> set up just for this type of thing, instead of trying to do this in the
> "core" kernel portions, where you have to deal with other real code
> changing happening at the same time.
> 

I guess I'll start with this instead of messing with the "core" code.
I'm still in my learning phase, so checkpatch cleanups are the only
contributions I can make for now. :D

> good luck!
> 
> greg k-h

Thanks a lot for your patience!

Atul