linux-kernel - Re: [PATCH 1/9] pstore/zone: cap the maximum device size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL3PxMr+Y2Jn1KabmqATWqq+EUJf1YN0_rKU+rQydbu9FiAvAQ@mail.gmail.com>
Date:   Sun, 8 Nov 2020 22:05:16 +0800
From:   廖威雄 <gmpy.liaowx@...il.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Kees Cook <keescook@...omium.org>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        WeiXiong Liao <liaoweixiong@...winnertech.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] pstore/zone: cap the maximum device size

On Fri, Oct 16, 2020 at 9:27 PM Christoph Hellwig <hch@....de> wrote:
>
> Introduce an abritrary 128MiB cap to avoid malloc failures when using
> a larger block device.
>
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  fs/pstore/zone.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/fs/pstore/zone.c b/fs/pstore/zone.c
> index 3ce89216670c9b..5266ccbec007f3 100644
> --- a/fs/pstore/zone.c
> +++ b/fs/pstore/zone.c
> @@ -1299,6 +1299,10 @@ int register_pstore_zone(struct pstore_zone_info *info)
>                 pr_warn("total_size must be >= 4096\n");
>                 return -EINVAL;
>         }
> +       if (info->total_size > SZ_128M) {
> +               pr_warn("capping size to 128MiB\n");
> +               info->total_size = SZ_128M;
> +       }
>

Reviewed-by: WeiXiong Liao <gmpy.liaowx@...il.com>


>         if (!info->kmsg_size && !info->pmsg_size && !info->console_size &&
>             !info->ftrace_size) {
> --
> 2.28.0
>