linux-kernel - Re: [PATCH] iio: light: fix kconfig dependency bug for VCNL4035

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201108154420.4982d232@archlinux>
Date:   Sun, 8 Nov 2020 15:44:20 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Necip Fazil Yildiran <fazilyildiran@...il.com>
Cc:     pn@...x.de, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, paul@...zz.com, jeho@...utexas.edu
Subject: Re: [PATCH] iio: light: fix kconfig dependency bug for VCNL4035

On Tue,  3 Nov 2020 01:35:24 +0300
Necip Fazil Yildiran <fazilyildiran@...il.com> wrote:

> When VCNL4035 is enabled and IIO_BUFFER is disabled, it results in the
> following Kbuild warning:
> 
> WARNING: unmet direct dependencies detected for IIO_TRIGGERED_BUFFER
>   Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
>   Selected by [y]:
>   - VCNL4035 [=y] && IIO [=y] && I2C [=y]
> 
> The reason is that VCNL4035 selects IIO_TRIGGERED_BUFFER without depending
> on or selecting IIO_BUFFER while IIO_TRIGGERED_BUFFER depends on
> IIO_BUFFER. This can also fail building the kernel.
> 
> Honor the kconfig dependency to remove unmet direct dependency warnings
> and avoid any potential build failures.
> 
> Fixes: 55707294c4eb ("iio: light: Add support for vishay vcnl4035")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=209883
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@...il.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

> ---
>  drivers/iio/light/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
> index cade6dc0305b..33ad4dd0b5c7 100644
> --- a/drivers/iio/light/Kconfig
> +++ b/drivers/iio/light/Kconfig
> @@ -544,6 +544,7 @@ config VCNL4000
>  
>  config VCNL4035
>  	tristate "VCNL4035 combined ALS and proximity sensor"
> +	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER
>  	select REGMAP_I2C
>  	depends on I2C