linux-kernel - Re: [PATCH net-next 1/1] net: phy: Allow mdio buses to probe C45 before falling back to C22

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Nov 2020 14:32:46 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Wong Vee Khee <vee.khee.wong@...el.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Ong Boon Leong <boon.leong.ong@...el.com>,
        Voon Wei Feng <weifeng.voon@...el.com>
Subject: Re: [PATCH net-next 1/1] net: phy: Allow mdio buses to probe C45
 before falling back to C22

On Mon, Nov 09, 2020 at 08:43:47PM +0800, Wong Vee Khee wrote:
> This patch makes mdiobus_scan() to try on C45 first as C45 can access
> all devices. This allows the function available for the PHY that
> supports for both C45 and C22.
> 
> Reviewed-by: Voon Weifeng <weifeng.voon@...el.com>
> Reviewed-by: Ong Boon Leong <boon.leong.ong@...el.com>
> Signed-off-by: Wong Vee Khee <vee.khee.wong@...el.com>

Hi

You need to add a user of this.

And i would like to see a more detailed explanation of why it is
needed. The PHY driver is free to do either C45 or C22 transfers.
Why does it care how the device was found?
Plus you can generally access C45 registers via the C45 over C22.  If
the PHY does not allow C45 over C22, then i expect the driver needs to
be aware of if the PHY can be access either way, and it needs to do
different things. And there is no PHY driver that i know of which does
this.

So before this goes any further, we need to see the bigger picture.

   Andrew