linux-kernel - [PATCH][next] cpumask: allocate enough space for string and trailing '\0' char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201109130447.2080491-1-colin.king@canonical.com>
Date:   Mon,  9 Nov 2020 13:04:47 +0000
From:   Colin King <colin.king@...onical.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>,
        "Paul E . McKenney" <paulmck@...nel.org>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH][next] cpumask: allocate enough space for string and trailing '\0' char

From: Colin Ian King <colin.king@...onical.com>

Currently the allocation of cpulist is based on the length of buf but does
not include the addition end of string '\0' terminator. Static analysis is
reporting this as a potential out-of-bounds access on cpulist. Fix this by
allocating enough space for the additional '\0' terminator.

Addresses-Coverity: ("Out-of-bounds access")
Fixes: 65987e67f7ff ("cpumask: add "last" alias for cpu list specifications")
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 lib/cpumask.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/cpumask.c b/lib/cpumask.c
index 34ecb3005941..cb8a3ef0e73e 100644
--- a/lib/cpumask.c
+++ b/lib/cpumask.c
@@ -185,7 +185,7 @@ int __ref cpulist_parse(const char *buf, struct cpumask *dstp)
 {
 	int r;
 	char *cpulist, last_cpu[5];	/* NR_CPUS <= 9999 */
-	size_t len = strlen(buf);
+	size_t len = strlen(buf) + 1;
 	bool early = !slab_is_available();
 
 	if (!strcmp(buf, "all")) {
-- 
2.28.0