linux-kernel - Re: [PATCH] thinkpad_acpi: add P1 gen3 second fan support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b5ec9ac-a587-2b6e-83da-f3b3c18efd43@redhat.com>
Date:   Mon, 9 Nov 2020 14:37:28 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Iakov 'Jake' Kirilenko <jake.kirilenko@...il.com>,
        Henrique de Moraes Holschuh <ibm-acpi@....eng.br>
Cc:     Mark Gross <mgross@...ux.intel.com>,
        ibm-acpi-devel@...ts.sourceforge.net,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thinkpad_acpi: add P1 gen3 second fan support

Hi,

On 11/5/20 4:25 PM, Iakov 'Jake' Kirilenko wrote:
> Tested on my P1 gen3, works fine with `thinkfan`. Since thinkpad_acpi fan
> control is off by default, it is safe to add 2nd fan control for brave
> overclockers
> 
> Signed-off-by: Iakov 'Jake' Kirilenko <jake.kirilenko@...il.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/thinkpad_acpi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index e38106750..4d64ba291 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -8776,6 +8776,7 @@ static const struct tpacpi_quirk fan_quirk_table[] __initconst = {
>  	TPACPI_Q_LNV3('N', '2', 'C', TPACPI_FAN_2CTL),	/* P52 / P72 */
>  	TPACPI_Q_LNV3('N', '2', 'E', TPACPI_FAN_2CTL),	/* P1 / X1 Extreme (1st gen) */
>  	TPACPI_Q_LNV3('N', '2', 'O', TPACPI_FAN_2CTL),	/* P1 / X1 Extreme (2nd gen) */
> +	TPACPI_Q_LNV3('N', '2', 'V', TPACPI_FAN_2CTL),	/* P1 / X1 Extreme (3nd gen) */
>  };
>  
>  static int __init fan_init(struct ibm_init_struct *iibm)
>