linux-kernel - Re: [PATCH] fs/coda: remove useless varible 'err'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201109144141.63uvxmjs2sokrqt2@cs.cmu.edu>
Date:   Mon, 9 Nov 2020 09:41:41 -0500
From:   Jan Harkes <jaharkes@...cmu.edu>
To:     Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/coda: remove useless varible 'err'

On Fri, Nov 06, 2020 at 10:57:08PM +0800, Alex Shi wrote:
> The variable is unused and cause gcc warning:
> fs/coda/file.c:241:6: warning: variable ‘err’ set but not used
> [-Wunused-but-set-variable]
> So let's remove it.
> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Cc: Jan Harkes <jaharkes@...cmu.edu> 
> Cc: coda@...cmu.edu 
> Cc: codalist@...a.cs.cmu.edu 
> Cc: linux-kernel@...r.kernel.org 

Looks good to me.

Acked-by: Jan Harkes <jaharkes@...cmu.edu>

> ---
>  fs/coda/file.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/coda/file.c b/fs/coda/file.c
> index 128d63df5bfb..31a7ba383cb2 100644
> --- a/fs/coda/file.c
> +++ b/fs/coda/file.c
> @@ -238,11 +238,10 @@ int coda_release(struct inode *coda_inode, struct file *coda_file)
>  	struct coda_file_info *cfi;
>  	struct coda_inode_info *cii;
>  	struct inode *host_inode;
> -	int err;
>  
>  	cfi = coda_ftoc(coda_file);
>  
> -	err = venus_close(coda_inode->i_sb, coda_i2f(coda_inode),
> +	venus_close(coda_inode->i_sb, coda_i2f(coda_inode),
>  			  coda_flags, coda_file->f_cred->fsuid);
>  
>  	host_inode = file_inode(cfi->cfi_container);
> -- 
> 1.8.3.1
> 
>