linux-kernel - Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <009ea5da-8a44-3ea2-1b9f-a658a09f3396@tessares.net>
Date:   Mon, 9 Nov 2020 17:28:54 +0100
From:   Matthieu Baerts <matthieu.baerts@...sares.net>
To:     Geliang Tang <geliangtang@...il.com>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, mptcp@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in
 mptcp_pm_add_timer

Hi Geliang, Dan,

On 09/11/2020 14:59, Geliang Tang wrote:
> Fix the following Smatch complaint:

Thanks for the report and the patch!

>       net/mptcp/pm_netlink.c:213 mptcp_pm_add_timer()
>       warn: variable dereferenced before check 'msk' (see line 208)
> 
>   net/mptcp/pm_netlink.c
>      207          struct mptcp_sock *msk = entry->sock;
>      208          struct sock *sk = (struct sock *)msk;
>      209          struct net *net = sock_net(sk);
>                                             ^^
>   "msk" dereferenced here.
> 
>      210
>      211          pr_debug("msk=%p", msk);
>      212
>      213          if (!msk)
>                      ^^^^
>   Too late.
> 
>      214                  return;
>      215
> 
> Fixes: 93f323b9cccc ("mptcp: add a new sysctl add_addr_timeout")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

A small detail (I think): the Signed-off-by of the sender (Geliang) 
should be the last one in the list if I am not mistaken.
But I guess this is not blocking.

Reviewed-by: Matthieu Baerts <matthieu.baerts@...sares.net>

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net