linux-kernel - Re: [PATCH v1] dt-bindings: arm: stm32: lxa,stm32mp157c-mc1: add extra SiP compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201109163733.GA1404197@bogus>
Date:   Mon, 9 Nov 2020 10:37:33 -0600
From:   Rob Herring <robh@...nel.org>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc:     Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        kernel@...gutronix.de, devicetree@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] dt-bindings: arm: stm32: lxa,stm32mp157c-mc1: add
 extra SiP compatible

On Wed, Nov 04, 2020 at 12:39:31PM +0100, Ahmad Fatoum wrote:
> The Linux Automation MC-1 is built around a SIP with CPU, RAM, PMIC,
> Oscillator and EEPROM. Add a further compatible identifying the SiP,
> so boot firmware can match against it to apply fixups if necessary.
> 
> To avoid intermittent dtbs_check breakage in the sole upstream device
> tree that uses that SiP, patch it here as well.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
> ---
> I know that bindings and device tree patches should be separate. Does
> this apply here as well? Should I split the dts change into a follow-up
> commit? 

Yes.

> Is it ok that dtbs_check will report an intermittent breakage?

If the binding comes first, it won't break.

But generally, 'dtbs_check' being warning free is not yet a requirement. 
That will probably first have to be per platform.

> ---
>  Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 8 +++++++-
>  arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts              | 2 +-
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> index 009b424e456e..9127094f0208 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> @@ -40,7 +40,6 @@ properties:
>        - items:
>            - enum:
>                - arrow,stm32mp157a-avenger96 # Avenger96
> -              - lxa,stm32mp157c-mc1
>                - shiratech,stm32mp157a-iot-box # IoT Box
>                - shiratech,stm32mp157a-stinger96 # Stinger96
>                - st,stm32mp157c-ed1
> @@ -52,6 +51,13 @@ properties:
>            - const: st,stm32mp157c-ev1
>            - const: st,stm32mp157c-ed1
>            - const: st,stm32mp157
> +      - description: Octavo OSD32MP15x System-in-Package based boards
> +        items:
> +          - enum:
> +              - lxa,stm32mp157c-mc1 # Linux Automation MC-1
> +          - const: oct,stm32mp15xx-osd32

'oct' is not docuemnted in vendor-prefixes.yaml.

> +          - enum:
> +              - st,stm32mp157
>        - description: Odyssey STM32MP1 SoM based Boards
>          items:
>            - enum:
> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> index 1e5333fd437f..cda8e871f999 100644
> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> @@ -15,7 +15,7 @@
>  
>  / {
>  	model = "Linux Automation MC-1 board";
> -	compatible = "lxa,stm32mp157c-mc1", "st,stm32mp157";
> +	compatible = "lxa,stm32mp157c-mc1", "oct,stm32mp15xx-osd32", "st,stm32mp157";
>  
>  	aliases {
>  		ethernet0 = &ethernet0;
> -- 
> 2.28.0
>