linux-kernel - Re: [PATCH 03/11 v3] ftrace: Optimize testing what context current is in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201109115151.1d841d97@oasis.local.home>
Date:   Mon, 9 Nov 2020 11:51:51 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Jiri Kosina <jikos@...nel.org>,
        Miroslav Benes <mbenes@...e.cz>, Petr Mladek <pmladek@...e.com>
Subject: Re: [PATCH 03/11 v3] ftrace: Optimize testing what context current
 is in

On Mon, 9 Nov 2020 13:17:08 +0100
Peter Zijlstra <peterz@...radead.org> wrote:

> This patch is misleading, it doesn't optimize it nearly as much as is
> possible and actually fixes the softirq case, which isn't at all
> mentioned.

This is actually an old patch I had for some time (it's been in the
ring buffer code for a while). I honestly didn't even realize that it
fixed softirq, which is why it isn't mentioned ;-)

I only said "optimize" I didn't say "optimal", thus it can be improved
more. When I first wrote this, I saw non noise improvements with it, so
it does indeed optimize it.

> 
> Let me go do that other patch.

I'll keep this patch, and replace the code when your version is
available.

Thanks!

-- Steve