linux-kernel - Re: [PATCH] f2fs: avoid unneeded data copy in f2fs_ioc_move

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201109170035.GA2129970@google.com>
Date:   Mon, 9 Nov 2020 09:00:35 -0800
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net, kernel-team@...roid.com
Cc:     Chao Yu <yuchao0@...wei.com>
Subject: Re: [PATCH] f2fs: avoid unneeded data copy in f2fs_ioc_move_range()

Sorry, please ignore this.

On 11/09, Jaegeuk Kim wrote:
> From: Chao Yu <yuchao0@...wei.com>
> 
> Fields in struct f2fs_move_range won't change in f2fs_ioc_move_range(),
> let's avoid copying this structure's data to userspace.
> 
> Signed-off-by: Chao Yu <yuchao0@...wei.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> ---
>  fs/f2fs/file.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 52417a2e3f4f..22ae8ae0072f 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -2898,12 +2898,6 @@ static int f2fs_ioc_move_range(struct file *filp, unsigned long arg)
>  					range.pos_out, range.len);
>  
>  	mnt_drop_write_file(filp);
> -	if (err)
> -		goto err_out;
> -
> -	if (copy_to_user((struct f2fs_move_range __user *)arg,
> -						&range, sizeof(range)))
> -		err = -EFAULT;
>  err_out:
>  	fdput(dst);
>  	return err;
> -- 
> 2.29.2.222.g5d2a92d10f8-goog