[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <SN4PR0201MB3472051AEFD34AB114827ABBCBEA0@SN4PR0201MB3472.namprd02.prod.outlook.com>
Date: Mon, 9 Nov 2020 17:10:24 +0000
From: Dragan Cvetic <draganc@...inx.com>
To: Harshal Chaudhari <harshalchau04@...il.com>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC: Derek Kiernan <dkiernan@...inx.com>,
"arnd@...db.de" <arnd@...db.de>, Michal Simek <michals@...inx.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] misc: xilinx_sdfec: add compat_ptr_ioctl()
> -----Original Message-----
> From: Harshal Chaudhari <harshalchau04@...il.com>
> Sent: Monday 26 October 2020 15:58
> To: gregkh@...uxfoundation.org
> Cc: Derek Kiernan <dkiernan@...inx.com>; Dragan Cvetic <draganc@...inx.com>; arnd@...db.de; Michal Simek
> <michals@...inx.com>; linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] misc: xilinx_sdfec: add compat_ptr_ioctl()
>
> Driver has a trivial helper function to convert
> the pointer argument and then call the native ioctl handler.
> But now we have a generic implementation for that, so we can use it.
>
> Signed-off-by: Harshal Chaudhari <harshalchau04@...il.com>
> ---
> drivers/misc/xilinx_sdfec.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> index 92291292756a..6f252793dceb 100644
> --- a/drivers/misc/xilinx_sdfec.c
> +++ b/drivers/misc/xilinx_sdfec.c
> @@ -1016,14 +1016,6 @@ static long xsdfec_dev_ioctl(struct file *fptr, unsigned int cmd,
> return rval;
> }
>
> -#ifdef CONFIG_COMPAT
> -static long xsdfec_dev_compat_ioctl(struct file *file, unsigned int cmd,
> - unsigned long data)
> -{
> - return xsdfec_dev_ioctl(file, cmd, (unsigned long)compat_ptr(data));
> -}
> -#endif
> -
> static __poll_t xsdfec_poll(struct file *file, poll_table *wait)
> {
> __poll_t mask = 0;
> @@ -1054,9 +1046,7 @@ static const struct file_operations xsdfec_fops = {
> .release = xsdfec_dev_release,
> .unlocked_ioctl = xsdfec_dev_ioctl,
> .poll = xsdfec_poll,
> -#ifdef CONFIG_COMPAT
> - .compat_ioctl = xsdfec_dev_compat_ioctl,
> -#endif
> + .compat_ioctl = compat_ptr_ioctl,
> };
>
> static int xsdfec_parse_of(struct xsdfec_dev *xsdfec)
> --
> 2.17.1
Acked-by: Dragan Cvetic <dragan.cvetic@...inx.com>
Powered by blists - more mailing lists