linux-kernel - RE: [PATCH] scsi: bnx2fc: fix comparison to bool warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR18MB3034D9FD587A112D92062257D2EA0@DM6PR18MB3034.namprd18.prod.outlook.com>
Date:   Mon, 9 Nov 2020 04:56:40 +0000
From:   Saurav Kashyap <skashyap@...vell.com>
To:     "xiakaixu1987@...il.com" <xiakaixu1987@...il.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kaixu Xia <kaixuxia@...cent.com>
Subject: RE: [PATCH] scsi: bnx2fc: fix comparison to bool warning

Hi,


> -----Original Message-----
> From: xiakaixu1987@...il.com <xiakaixu1987@...il.com>
> Sent: Saturday, November 7, 2020 10:22 PM
> To: jejb@...ux.ibm.com; martin.petersen@...cle.com
> Cc: linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; Kaixu Xia
> <kaixuxia@...cent.com>
> Subject: [PATCH] scsi: bnx2fc: fix comparison to bool warning
> 
> From: Kaixu Xia <kaixuxia@...cent.com>
> 
> Fix the following coccicheck warning:
> 
> ./drivers/scsi/bnx2fc/bnx2fc_fcoe.c:2089:5-23: WARNING: Comparison to bool
> ./drivers/scsi/bnx2fc/bnx2fc_fcoe.c:2187:5-23: WARNING: Comparison to bool
> 
> Reported-by: Tosk Robot <tencent_os_robot@...cent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>
> ---
>  drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> index 6890bbe04a8c..b612f5ea647e 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> @@ -2086,7 +2086,7 @@ static int __bnx2fc_disable(struct fcoe_ctlr *ctlr)
>  {
>  	struct bnx2fc_interface *interface = fcoe_ctlr_priv(ctlr);
> 
> -	if (interface->enabled == true) {
> +	if (interface->enabled) {
>  		if (!ctlr->lp) {
>  			pr_err(PFX "__bnx2fc_disable: lport not found\n");
>  			return -ENODEV;
> @@ -2184,7 +2184,7 @@ static int __bnx2fc_enable(struct fcoe_ctlr *ctlr)
>  	struct cnic_fc_npiv_tbl *npiv_tbl;
>  	struct fc_lport *lport;
> 
> -	if (interface->enabled == false) {
> +	if (!interface->enabled) {
>  		if (!ctlr->lp) {
>  			pr_err(PFX "__bnx2fc_enable: lport not found\n");
>  			return -ENODEV;
>
Thanks for a patch.

Acked-by: Saurav Kashyap <skashyap@...vell.com>

Thanks,
~Saurav
 --
> 2.20.0