linux-kernel - Re: [PATCH 0/3] HDR10 static metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f907743dbb77f4c2f871675070065dd372514be.camel@collabora.com>
Date:   Mon, 09 Nov 2020 14:53:55 -0500
From:   Nicolas Dufresne <nicolas.dufresne@...labora.com>
To:     Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Cc:     Ezequiel Garcia <ezequiel@...labora.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>
Subject: Re: [PATCH 0/3] HDR10 static metadata

Le lundi 09 novembre 2020 à 19:31 +0200, Stanimir Varbanov a écrit :
> Hello,
> 
> This patchset adds two HDR10 HEVC v4l2 controls for Content Light Level
> and Mastering display colour volume plus implenmentation in Venus encoder
> driver.
> 
> Comments are welcome!

It is not a formal review, but I did walked through the new API and
everything looks fine to me. One question though, are you aware that
the H.264/AVC equivalent is identical ? What is you plan for that ?

> 
> regards,
> Stan
> 
> Stanimir Varbanov (3):
>   v4l: Add HDR10 HEVC static metadata controls
>   docs: media: Document CLL and Mastering display
>   venus: venc: Add support for CLL and Mastering display controls
> 
>  .../media/v4l/ext-ctrls-codec.rst             | 61 +++++++++++++++++++
>  drivers/media/platform/qcom/venus/core.h      |  3 +
>  drivers/media/platform/qcom/venus/hfi_cmds.c  |  8 +++
>  .../media/platform/qcom/venus/hfi_helper.h    | 20 ++++++
>  drivers/media/platform/qcom/venus/venc.c      | 29 +++++++++
>  .../media/platform/qcom/venus/venc_ctrls.c    | 16 ++++-
>  drivers/media/v4l2-core/v4l2-ctrls.c          | 61 +++++++++++++++++++
>  include/media/hevc-ctrls.h                    | 41 +++++++++++++
>  include/media/v4l2-ctrls.h                    |  2 +
>  9 files changed, 240 insertions(+), 1 deletion(-)
> 


Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)