linux-kernel - RE: [PATCH] bpf: remove duplicate include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5fa9b0f5eb2f6_8c0e20854@john-XPS-13-9370.notmuch>
Date:   Mon, 09 Nov 2020 13:13:25 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Wang Qing <wangqing@...o.com>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andrii@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Wang Qing <wangqing@...o.com>
Subject: RE: [PATCH] bpf: remove duplicate include

Wang Qing wrote:
> Remove duplicate header which is included twice.
> 
> Signed-off-by: Wang Qing <wangqing@...o.com>
> ---
>  kernel/bpf/btf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> index ed7d02e..6324de8
> --- a/kernel/bpf/btf.c
> +++ b/kernel/bpf/btf.c
> @@ -22,7 +22,6 @@
>  #include <linux/skmsg.h>
>  #include <linux/perf_event.h>
>  #include <linux/bsearch.h>
> -#include <linux/btf_ids.h>
>  #include <net/sock.h>
>  
>  /* BTF (BPF Type Format) is the meta data format which describes
> -- 
> 2.7.4
> 

Looks fine to me. But, these types of things should go to bpf-next I
see no reason to push these into bpf tree.