linux-kernel - Re: [tip: x86/apic] x86/io_apic: Cleanup trigger/polarity helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2e06979-cbcf-8771-0b48-c46f2d034aa8@amd.com>
Date:   Mon, 9 Nov 2020 17:15:03 -0600
From:   Tom Lendacky <thomas.lendacky@....com>
To:     linux-kernel@...r.kernel.org
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        David Woodhouse <dwmw@...zon.co.uk>, x86 <x86@...nel.org>
Subject: Re: [tip: x86/apic] x86/io_apic: Cleanup trigger/polarity helpers

On 10/29/20 7:15 AM, tip-bot2 for Thomas Gleixner wrote:
> The following commit has been merged into the x86/apic branch of tip:
> 
> Commit-ID:     a27dca645d2c0f31abb7858aa0e10b2fa0f2f659
> Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=a27dca645d2c0f31abb7858aa0e10b2fa0f2f659
> Author:        Thomas Gleixner <tglx@...utronix.de>
> AuthorDate:    Sat, 24 Oct 2020 22:35:19 +01:00
> Committer:     Thomas Gleixner <tglx@...utronix.de>
> CommitterDate: Wed, 28 Oct 2020 20:26:26 +01:00
> 
> x86/io_apic: Cleanup trigger/polarity helpers
> 
> 'trigger' and 'polarity' are used throughout the I/O-APIC code for handling
> the trigger type (edge/level) and the active low/high configuration. While
> there are defines for initializing these variables and struct members, they
> are not used consequently and the meaning of 'trigger' and 'polarity' is
> opaque and confusing at best.
> 
> Rename them to 'is_level' and 'active_low' and make them boolean in various
> structs so it's entirely clear what the meaning is.

Running the tip tree on my second generation EPYC system I'm seeing lots
of the following:

[  105.325371] hpet: Lost 9601 RTC interrupts
[  105.485766] hpet: Lost 9600 RTC interrupts
[  105.639182] hpet: Lost 9601 RTC interrupts
[  105.792155] hpet: Lost 9601 RTC interrupts
[  105.947076] hpet: Lost 9601 RTC interrupts
[  106.100876] hpet: Lost 9600 RTC interrupts
[  106.253444] hpet: Lost 9601 RTC interrupts
[  106.406722] hpet: Lost 9601 RTC interrupts

preventing the system from booting. I bisected it to this commit.

Additionally, I'm seeing warnings and error messages (which I haven't
bisected, yet) along these lines:

[   12.790801] WARNING: CPU: 135 PID: 1 at arch/x86/kernel/apic/apic.c:2505 __irq_msi_compose_msg+0x79/0x80
[   98.121716] irq 3: nobody cared (try booting with the "irqpoll" option)
[  100.692087] irq 15: nobody cared (try booting with the "irqpoll" option)
[  100.800217] irq 11: nobody cared (try booting with the "irqpoll" option)
[  100.800407] irq 10: nobody cared (try booting with the "irqpoll" option)

Thanks,
Tom