linux-kernel - Re: [PATCH v5 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=UUS1U5YmOFjioU12o3ayb8W2rFh9bPTfaeGiBxZ0cXHg@mail.gmail.com>
Date:   Mon, 9 Nov 2020 15:23:39 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Jiri Kosina <jkosina@...e.cz>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Andrea Borgia <andrea@...gia.bo.it>,
        Jiri Kosina <jikos@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Pavel Balan <admin@...ma.net>,
        Xiaofei Tan <tanxiaofei@...wei.com>,
        You-Sheng Yang <vicamo.yang@...onical.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 1/4] HID: i2c-hid: Reorganize so ACPI and OF are
 separate modules

Hi,

On Mon, Nov 9, 2020 at 1:37 PM Douglas Anderson <dianders@...omium.org> wrote:
>
> +int i2c_hid_acpi_probe(struct i2c_client *client,
> +                      const struct i2c_device_id *dev_id)
> +{
> +       struct device *dev = &client->dev;
> +       struct i2c_hid_acpi *ihid_acpi;
> +       u16 hid_descriptor_address;
> +       int ret;
> +
> +       ihid_acpi = devm_kzalloc(&client->dev, sizeof(*ihid_acpi), GFP_KERNEL);
> +       if (!ihid_acpi)
> +               return -ENOMEM;
> +

Turns out one way to find some folks to help me test this code is to
break them.  Maybe not a good way, but a way.  :(

There should have been a:

ihid_acpi->client = client;

...here.  If you're willing to look at Chrome OS gerrit pages, you can
find the fix at <https://crrev.com/c/2527946>.

If everything about this patch looks good, I'm OK w/ a maintainer
fixing this when applying.  I'm also happy to send out a v6, but I'll
wait a little bit in case there are other comments.


-Doug