linux-kernel - Re: [PATCH] net/mlx4: Assign boolean values to a bool variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6901fed-d063-91be-afd6-b6eedb2b65b6@gmail.com>
Date:   Mon, 9 Nov 2020 15:07:52 +0800
From:   kaixuxia <xiakaixu1987@...il.com>
To:     Tariq Toukan <ttoukan.linux@...il.com>, tariqt@...dia.com,
        tariqt@...lanox.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [PATCH] net/mlx4: Assign boolean values to a bool variable



On 2020/11/8 16:20, Tariq Toukan wrote:
> 
> 
> On 11/7/2020 8:53 AM, xiakaixu1987@...il.com wrote:
>> From: Kaixu Xia <kaixuxia@...cent.com>
>>
>> Fix the following coccinelle warnings:
>>
> 
> Hi Kaixu,
> 
> Which coccinelle version gave this warning?

Hi Tariq,

The version is coccinelle-1.0.7.

Thanks,
Kaixu
> 
> 
>> ./drivers/net/ethernet/mellanox/mlx4/en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable
>>
>> Reported-by: Tosk Robot <tencent_os_robot@...cent.com>
>> Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>
>> ---
>>   drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
>> index 502d1b97855c..b0f79a5151cf 100644
>> --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
>> +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
>> @@ -684,7 +684,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
>>       xdp_prog = rcu_dereference(ring->xdp_prog);
>>       xdp.rxq = &ring->xdp_rxq;
>>       xdp.frame_sz = priv->frag_info[0].frag_stride;
>> -    doorbell_pending = 0;
>> +    doorbell_pending = false;
>>         /* We assume a 1:1 mapping between CQEs and Rx descriptors, so Rx
>>        * descriptor offset can be deduced from the CQE index instead of
>>
> 

-- 
kaixuxia