linux-kernel - Re: [PATCH] video: fbdev: riva: remove some unused varibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201109073127.GC1715181@ravnborg.org>
Date:   Mon, 9 Nov 2020 08:31:27 +0100
From:   Sam Ravnborg <sam@...nborg.org>
To:     Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: riva: remove some unused varibles

Hi Alex,

On Sun, Nov 08, 2020 at 04:01:59PM +0800, Alex Shi wrote:
> Couple of variables are actually useless, remove them to save some gcc
> warning:
> drivers/video/fbdev/riva/riva_hw.c:250:21: warning: variable ‘mlwm’ set
> but not used [-Wunused-but-set-variable]
> drivers/video/fbdev/riva/riva_hw.c:665:15: warning: variable ‘vraw’ set
> but not used [-Wunused-but-set-variable]
> drivers/video/fbdev/riva/riva_hw.c:665:9: warning: variable ‘craw’ set
> but not used [-Wunused-but-set-variable]
> drivers/video/fbdev/riva/riva_hw.c:659:73: warning: variable ‘align’ set
> but not used [-Wunused-but-set-variable]
> drivers/video/fbdev/riva/riva_hw.c:659:50: warning: variable
> ‘color_key_enable’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Cc: Antonino Daplas <adaplas@...il.com> 
> Cc: linux-fbdev@...r.kernel.org 
> Cc: dri-devel@...ts.freedesktop.org 
> Cc: linux-kernel@...r.kernel.org 

Thanks, applied to drm-misc-next. The fix will appear in -next in a week
or so.

	Sam