linux-kernel - Re: [PATCH v2] mm/gup_test: GUP_TEST depends on DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <071150d8-9159-91c4-118d-b19c2bd785ea@infradead.org>
Date:   Sun, 8 Nov 2020 23:52:14 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     John Hubbard <jhubbard@...dia.com>,
        Barry Song <song.bao.hua@...ilicon.com>,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Cc:     linuxarm@...wei.com, Ralph Campbell <rcampbell@...dia.com>,
        John Garry <john.garry@...wei.com>
Subject: Re: [PATCH v2] mm/gup_test: GUP_TEST depends on DEBUG_FS

On 11/8/20 11:45 PM, John Hubbard wrote:
> On 11/8/20 12:37 AM, Barry Song wrote:
>> Without DEBUG_FS, all the code in gup_test becomes meaningless. For sure
>> kernel provides debugfs stub while DEBUG_FS is disabled, but the point
>> here is that GUP_TEST can do nothing without DEBUG_FS.
>>
>> Cc: John Hubbard <jhubbard@...dia.com>
>> Cc: Ralph Campbell <rcampbell@...dia.com>
>> Cc: Randy Dunlap <rdunlap@...radead.org>
>> Suggested-by: John Garry <john.garry@...wei.com>
>> Signed-off-by: Barry Song <song.bao.hua@...ilicon.com>
>> ---
>>   -v2:
>>   add comment as a prompt to users as commented by John and Randy, thanks!
>>
>>   mm/Kconfig | 4 ++++
>>   1 file changed, 4 insertions(+)
> 
> Thanks for suffering through a lot of discussion about this!
> 
> Reviewed-by: John Hubbard <jhubbard@...dia.com>
> 
> 
> thanks,

Acked-by: Randy Dunlap <rdunlap@...radead.org>

thanks.

-- 
~Randy