linux-kernel - Re: linux-next: build failure after merge of the drivers-memory tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Nov 2020 09:04:25 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the drivers-memory tree

On Mon, 9 Nov 2020 at 02:01, Dmitry Osipenko <digetx@...il.com> wrote:
>
> 09.11.2020 02:23, Stephen Rothwell пишет:
> > Hi all,
> >
> > After merging the drivers-memory tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > In file included from drivers/devfreq/tegra20-devfreq.c:18:
> > include/soc/tegra/mc.h: In function 'devm_tegra_memory_controller_get':
> > include/soc/tegra/mc.h:211:1: error: no return statement in function returning non-void [-Werror=return-type]
> >   211 | }
> >       | ^
> >
> > Caused by commit
> >
> >   1f1997eb44b1 ("memory: tegra: Add and use devm_tegra_memory_controller_get()")
> >
> > I have added the following fix patch for today:
> >
> > From: Stephen Rothwell <sfr@...b.auug.org.au>
> > Date: Mon, 9 Nov 2020 10:19:44 +1100
> > Subject: [PATCH] fix "memory: tegra: Add and use
> >  devm_tegra_memory_controller_get()"
> >
> > Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > ---
> >  include/soc/tegra/mc.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/soc/tegra/mc.h b/include/soc/tegra/mc.h
> > index 43876216de34..d731407e23bb 100644
> > --- a/include/soc/tegra/mc.h
> > +++ b/include/soc/tegra/mc.h
> > @@ -207,7 +207,7 @@ struct tegra_mc *devm_tegra_memory_controller_get(struct device *dev);
> >  static inline struct tegra_mc *
> >  devm_tegra_memory_controller_get(struct device *dev)
> >  {
> > -     ERR_PTR(-ENODEV);
> > +     return ERR_PTR(-ENODEV);
> >  }
> >  #endif
>
> Krzysztof, will you be able correct this typo locally, or should I add a
> new patch?

Send a new patch please with Stephen's reported-by.

Best regards,
Krzysztof