linux-kernel - Re: [PATCH RESEND] driver core: export device_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Nov 2020 11:37:03 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     "Rafael J . Wysocki" <rafael@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Dong Aisheng <aisheng.dong@....com>
Subject: Re: [PATCH RESEND] driver core: export device_is_bound() to fix
 build failure

On Mon, Nov 09, 2020 at 10:14:46AM +0000, Sudip Mukherjee wrote:
> Hi Greg,
> 
> On Sun, Nov 8, 2020 at 8:23 AM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > On Sat, Nov 07, 2020 at 10:47:27PM +0000, Sudip Mukherjee wrote:
> > > When CONFIG_MXC_CLK_SCU is configured as 'm' the build fails as it
> > > is unable to find device_is_bound(). The error being:
> > > ERROR: modpost: "device_is_bound" [drivers/clk/imx/clk-imx-scu.ko]
> > >       undefined!
> > >
> > > Export the symbol so that the module finds it.
> > >
> > > Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support")
> > > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> > > ---
> > >
> > > resending with the Fixes: tag.
> > >
> > >  drivers/base/dd.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> > > index 148e81969e04..a796a57e5efb 100644
> > > --- a/drivers/base/dd.c
> > > +++ b/drivers/base/dd.c
> > > @@ -353,6 +353,7 @@ bool device_is_bound(struct device *dev)
> > >  {
> > >       return dev->p && klist_node_attached(&dev->p->knode_driver);
> > >  }
> > > +EXPORT_SYMBOL(device_is_bound);
> >
> > EXPORT_SYMBOL_GPL() please, like all the other exports in this file.
> >
> > Also, wait, no, don't call this, are you sure you are calling it in a
> > race-free way?  And what branch/tree is the above commit in?
> 
> I have not checked fully but since it is being called from probe() I
> assume the lock will be held at that time.

probe() should never call this function as it makes no sense at all at
that point in time.  The driver should be fixed.

This function should not be exported, sorry.

thanks,

greg k-h