linux-kernel - Re: [PATCH] arm64: PCI: Validate the node before setting node id for root bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd8b8138-c3f8-59f6-d57f-704ef5d28d46@linux.alibaba.com>
Date:   Mon, 9 Nov 2020 20:27:09 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc:     Will Deacon <will@...nel.org>, catalin.marinas@....com,
        baolin.wang7@...il.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: PCI: Validate the node before setting node id for
 root bus

Hi Lorenzo,

> 
>> On Tue, Sep 29, 2020 at 11:41:29PM +0800, Baolin Wang wrote:
>>> Hi,
>>>
>>> 锟斤拷 2020/9/28 23:23, Lorenzo Pieralisi 写锟斤拷:
>>>> On Mon, Sep 28, 2020 at 10:49:57PM +0800, Baolin Wang wrote:
>>>>> On Mon, Sep 28, 2020 at 03:00:55PM +0100, Will Deacon wrote:
>>>>>> [+ Lorenzo]
>>>>>>
>>>>>> On Tue, Sep 22, 2020 at 06:33:24PM +0800, Baolin Wang wrote:
>>>>>>> If the BIOS disabled the NUMA configuration, but did not change the
>>>>>>> proximity domain description in the SRAT table, so the PCI root bus
>>>>>>> device may get a incorrect node id by acpi_get_node().
>>>>>>
>>>>>> How "incorrect" are we talking here? What actually goes wrong? At 
>>>>>> some
>>>>>> point, we have to trust what the firmware is telling us.
>>>>>
>>>>> What I mean is, if we disable the NUMA from BIOS
>>>>
>>>> Please define what this means ie are you removing SRAT from ACPI static
>>>> tables ?
>>>
>>> Yes.
>>>
>>>>
>>>>> but we did not change the PXM for the PCI devices,
>>>>
>>>> If a _PXM maps to a proximity domain that is not described in the SRAT
>>>> your firmware is buggy.
>>>
>>> Sorry for confusing, that's not what I mean. When the BIOS disable 
>>> the NUMA
>>> (remove the SRAT table), but the PCI devices' _PXM description is still
>>> available, which means we can still get the pxm from 
>>> acpi_evaluate_integer()
>>> in this case.
>>
>> There should not be a _PXM object if the SRAT is not available, that's
>> a firmware bug.
>>
>>> So we can get below inconsistent log on ARM platform:
>>> "No NUMA configuration found
>>> PCI_bus 0000:00 on NUMA node 0
>>> ...
>>> PCI_bus 0000:e3 on NUMA node 1"
>>>
>>> On X86, the pci_acpi_root_get_node() will validate the node before 
>>> setting
>>> the node id for root bus. So I think we can add this validation for ARM
>>> platform. Or anything else I missed?
>>
>> We are not adding checks because x86 does it, it is certainly to paper
>> over a firmware bug that you hopefully still have a chance to fix,
>> let's do that instead of adding code that is not necessary.
> 
> Thanks for your input, and I will check this issue with our firmware 
> colleagues again.

Sorry for late reply.

I did some investigation for this issue. I am sorry I made some 
misleading description in the commit message. The issue is, when we
want to disable the NUMA from firmware, we usually just remove the SRAT 
table from the BIOS. But the devices' proximity domain information is 
still remain in the ACPI tables.

For example, the IORT table still contains the proximity domain 
information for the SMMU devices, so in this case, the SMMU devices 
still can get incorrect NUMA nodes if we remove the SRAT table. But
the SMMU devices will validate the numa node in 
arm_smmu_v3_set_proximity() to avoid this issue.

static int  __init arm_smmu_v3_set_proximity(struct device *dev,
					      struct acpi_iort_node *node)
{
	struct acpi_iort_smmu_v3 *smmu;

	smmu = (struct acpi_iort_smmu_v3 *)node->node_data;
	if (smmu->flags & ACPI_IORT_SMMU_V3_PXM_VALID) {
		int dev_node = pxm_to_node(smmu->pxm);

		if (dev_node != NUMA_NO_NODE && !node_online(dev_node))
			return -EINVAL;

		set_dev_node(dev, dev_node);
		pr_info("SMMU-v3[%llx] Mapped to Proximity domain %d\n",
			smmu->base_address,
			smmu->pxm);
	}
	return 0;
}

So similar with SMMU devices, the DSDT table will still contain the PCI 
root host devices' proximity domain though we already remove the SRAT 
table. So I think we still need this validation in 
pcibios_root_bridge_prepare() to avoid this issue like other devices did.

I can update the commit message in next version if you think this is 
reasonable. Thanks.