linux-kernel - Re: [PATCH] Bluetooth: hci_ll: add a small delay for wl1271 enable bt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <93858CE1-A293-4331-8B72-48BBAF7821D3@holtmann.org>
Date:   Mon, 9 Nov 2020 13:43:43 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     "Wang, Xiaolei" <Xiaolei.Wang@...driver.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Bluetooth: hci_ll: add a small delay for wl1271 enable
 bt_en

Hi Xiaolei,

> When using the wl1271 Bluetooth function of am335x, it is found that the Bluetooth module cannot respond in time after Bluetooth is enabled, and a small delay is needed to work normally, so whether to add a small mdelay.
>  
> Signed-off-by: Xiaolei Wang <xiaolei.wang@...driver.com>
> ---
> drivers/bluetooth/hci_ll.c | 1 +
> 1 file changed, 1 insertion(+)
>  
> diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c index 8bfe024d1fcd..eb1e736efeeb 100644
> --- a/drivers/bluetooth/hci_ll.c
> +++ b/drivers/bluetooth/hci_ll.c
> @@ -626,6 +626,7 @@ static int ll_setup(struct hci_uart *hu)
>                                gpiod_set_value_cansleep(lldev->enable_gpio, 0);
>                                msleep(5);
>                                gpiod_set_value_cansleep(lldev->enable_gpio, 1);
> +                             mdelay(100);
>                                err = serdev_device_wait_for_cts(serdev, true, 200);
>                                if (err) {
>                                                bt_dev_err(hu->hdev, "Failed to get CTS");

please submit patches in the proper format and encoding.

Regardes

Marcel