linux-kernel - Re: [PATCH resend2] sh/intc: Restore devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <370e55e9-afe7-1392-4816-3734d04351fb@gmail.com>
Date:   Tue, 10 Nov 2020 18:53:45 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>
Cc:     linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend2] sh/intc: Restore devm_ioremap() alignment

Hello!

On 11/10/20 6:49 PM, Geert Uytterhoeven wrote:

> Restore alignment of the continuation of the devm_ioremap() call in

   It's a plain ioremap() call below, isn't it, :-)

> register_intc_controller().
> 
> Fixes: 4bdc0d676a643140 ("remove ioremap_nocache and devm_ioremap_nocache")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/sh/intc/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/sh/intc/core.c b/drivers/sh/intc/core.c
> index f8e070d67fa3266d..a14684ffe4c1a8ef 100644
> --- a/drivers/sh/intc/core.c
> +++ b/drivers/sh/intc/core.c
> @@ -214,7 +214,7 @@ int __init register_intc_controller(struct intc_desc *desc)
>  			d->window[k].phys = res->start;
>  			d->window[k].size = resource_size(res);
>  			d->window[k].virt = ioremap(res->start,
> -							 resource_size(res));
> +						    resource_size(res));
>  			if (!d->window[k].virt)
>  				goto err2;
>  		}

MBR, Sergei