linux-kernel - Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Set partner num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba6c1415-457b-1e8d-b604-fad603fe9be6@collabora.com>
Date:   Tue, 10 Nov 2020 17:01:04 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Prashant Malani <pmalani@...omium.org>
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        gregkh@...uxfoundation.org, Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Set partner
 num_altmodes

Hi,

On 10/11/20 11:50, Heikki Krogerus wrote:
> On Mon, Nov 09, 2020 at 10:15:36PM -0800, Prashant Malani wrote:
>> Set the number of altmodes available for a registered partner using the
>> Type C connector class framework routine.
>>
>> Signed-off-by: Prashant Malani <pmalani@...omium.org>
> 
> Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> 

Acked-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

Heikki, would you like to take these two through your tree? It'd help if you can
create an inmutable branch so I can pick other cros_ec_typec patches on top of it.

Thanks,
 Enric

>> ---
>>
>> Changes in v2:
>> - Patch introduced for the first time in v2.
>>
>>  drivers/platform/chrome/cros_ec_typec.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
>> index ce031a10eb1b..743a28426f98 100644
>> --- a/drivers/platform/chrome/cros_ec_typec.c
>> +++ b/drivers/platform/chrome/cros_ec_typec.c
>> @@ -621,6 +621,7 @@ static int cros_typec_register_altmodes(struct cros_typec_data *typec, int port_
>>  	struct cros_typec_altmode_node *node;
>>  	struct typec_altmode_desc desc;
>>  	struct typec_altmode *amode;
>> +	int num_altmodes = 0;
>>  	int ret = 0;
>>  	int i, j;
>>  
>> @@ -647,9 +648,16 @@ static int cros_typec_register_altmodes(struct cros_typec_data *typec, int port_
>>  
>>  			node->amode = amode;
>>  			list_add_tail(&node->list, &port->partner_mode_list);
>> +			num_altmodes++;
>>  		}
>>  	}
>>  
>> +	ret = typec_partner_set_num_altmodes(port->partner, num_altmodes);
>> +	if (ret < 0) {
>> +		dev_err(typec->dev, "Unable to set partner num_altmodes for port: %d\n", port_num);
>> +		goto err_cleanup;
>> +	}
>> +
>>  	return 0;
>>  
>>  err_cleanup:
>> -- 
>> 2.29.2.222.g5d2a92d10f8-goog
> 
> thanks,
>