linux-kernel - Re: [PATCH] drm: DRM_KMB_DISPLAY should depend on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Nov 2020 17:15:23 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Anitha Chrisanthus <anitha.chrisanthus@...el.com>,
        Edmund Dea <edmund.j.dea@...el.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Sam Ravnborg <sam@...nborg.org>,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY

On Tue, Nov 10, 2020 at 03:43:50PM +0100, Geert Uytterhoeven wrote:
> The Intel Keem Bay display controller is only present on Intel Keem Bay
> SoCs.  Hence add a dependency on ARCH_KEEMBAY, to prevent asking the
> user about this driver when configuring a kernel without Intel Keem Bay
> platform support.
> 
> Note that:
>   1. The dependency on ARM is dropped, as Keem Bay SoCs are only
>      supported in arm64 kernel builds,
>   2. The dependencies on OF and COMMON_CLK can be dropped for
>      compile-testing, as the driver builds fine regardless.
> 
> Fixes: ed794057b052b52a ("drm/kmb: Build files for KeemBay Display driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Both drm/kmb fixes applied to drm-misc-next, thanks a lot!
-Daniel

> ---
>  drivers/gpu/drm/kmb/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/kmb/Kconfig b/drivers/gpu/drm/kmb/Kconfig
> index 022ef3e3f05635be..3921c57ac511e2fb 100644
> --- a/drivers/gpu/drm/kmb/Kconfig
> +++ b/drivers/gpu/drm/kmb/Kconfig
> @@ -1,7 +1,7 @@
>  config DRM_KMB_DISPLAY
>  	tristate "INTEL KEEMBAY DISPLAY"
> -	depends on DRM && OF && (ARM || ARM64)
> -	depends on COMMON_CLK
> +	depends on DRM
> +	depends on ARCH_KEEMBAY || COMPILE_TEST
>  	select DRM_KMS_HELPER
>  	select DRM_KMS_CMA_HELPER
>  	select DRM_GEM_CMA_HELPER
> -- 
> 2.25.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch