linux-kernel - Re: [PATCH v2] scsi: ufshcd: fix missing destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e765eb4f-a85d-72c8-3f82-1f321e3d6c3b@codeaurora.org>
Date:   Tue, 10 Nov 2020 10:17:57 -0800
From:   "Asutosh Das (asd)" <asutoshd@...eaurora.org>
To:     Qinglang Miao <miaoqinglang@...wei.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] scsi: ufshcd: fix missing destroy_workqueue()

On 11/9/2020 11:42 PM, Qinglang Miao wrote:
> Add the missing destroy_workqueue() before return from
> ufshcd_init in the error handling case as well as in
> ufshcd_remove.
> 
> Fixes: 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler and other error recovery paths")
> Suggested-by: Avri Altman <Avri.Altman@....com>
> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> ---

Reviewed-by: Asutosh Das <asutoshd@...eaurora.org>

>   v2: consider missing destroy_workqueue ufshcd_remove either.
> 
>   drivers/scsi/ufs/ufshcd.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index b8f573a02713..adbdda4f556b 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -8906,6 +8906,7 @@ void ufshcd_remove(struct ufs_hba *hba)
>   	blk_mq_free_tag_set(&hba->tmf_tag_set);
>   	blk_cleanup_queue(hba->cmd_queue);
>   	scsi_remove_host(hba->host);
> +	destroy_workqueue(hba->eh_wq);
>   	/* disable interrupts */
>   	ufshcd_disable_intr(hba, hba->intr_mask);
>   	ufshcd_hba_stop(hba);
> @@ -9206,6 +9207,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
>   exit_gating:
>   	ufshcd_exit_clk_scaling(hba);
>   	ufshcd_exit_clk_gating(hba);
> +	destroy_workqueue(hba->eh_wq);
>   out_disable:
>   	hba->is_irq_enabled = false;
>   	ufshcd_hba_exit(hba);
> 


-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project