linux-kernel - Re: [PATCH] arm64: tegra186: Add missing CPU PMUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59f8937f14ce485558ec957d0f73ba7d@kernel.org>
Date:   Tue, 10 Nov 2020 18:27:06 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Nagarjuna Kristam <nkristam@...dia.com>,
        Sowjanya Komatineni <skomatineni@...dia.com>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] arm64: tegra186: Add missing CPU PMUs

On 2020-11-10 18:22, Thierry Reding wrote:
> On Tue, Nov 10, 2020 at 06:08:31PM +0000, Marc Zyngier wrote:
>> On 2020-11-10 17:36, Thierry Reding wrote:
>> > On Tue, Oct 13, 2020 at 10:58:51AM +0100, Marc Zyngier wrote:
>> > > Add the description of CPU PMUs for both the Denver and A57 clusters,
>> > > which enables the perf subsystem.
>> > >
>> > > Signed-off-by: Marc Zyngier <maz@...nel.org>
>> 
>> [...]
>> 
>> > >
>> > > +	pmu_denver {
>> > > +		compatible = "nvidia,denver-pmu", "arm,armv8-pmuv3";
>> >
>> > checkpatch complains that this isn't documented. Did I miss the DT
>> > bindings patch or do we not have one for this?
>> 
>> We don't. But I don't think adding a compatible string for each
>> and every micro-architecture makes much sense unless we have something
>> useful to add to that compatible string. Such as a full description
>> of the implementation specific events.
> 
> I'm wondering if this isn't going to upset Rob's json-schema bot and
> make him mad.

Rob going mad? Never! ;-)

If you *really* want it, I'll respin this patch with the Denver 
compatible
added to Documentation/devicetree/bindings/arm/pmu.yaml.

         M.
-- 
Jazz is not dead. It just smells funny...