linux-kernel - Re: [PATCH v2 3/3] media: uapi: mpeg2: Split sequence and picture parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Nov 2020 21:56:23 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     kbuild@...ts.01.org, Ezequiel Garcia <ezequiel@...labora.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     lkp@...el.com, kbuild-all@...ts.01.org, kernel@...labora.com,
        Jonas Karlman <jonas@...boo.se>,
        Hans Verkuil <hverkuil@...all.nl>,
        Nicolas Dufresne <nicolas.dufresne@...labora.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Maxime Ripard <mripard@...nel.org>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        Jernej Skrabec <jernej.skrabec@...l.net>
Subject: Re: [PATCH v2 3/3] media: uapi: mpeg2: Split sequence and picture
 parameters

Hi Ezequiel,

url:    https://github.com/0day-ci/linux/commits/Ezequiel-Garcia/MPEG-2-stateless-API-cleanup/20201106-045304
base:   git://linuxtv.org/media_tree.git master
config: i386-randconfig-m021-20201110 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Dan Carpenter <dan.carpenter@...cle.com>

smatch warnings:
drivers/media/v4l2-core/v4l2-ctrls.c:1809 std_validate_compound() warn: ignoring unreachable code.

vim +1809 drivers/media/v4l2-core/v4l2-ctrls.c

de8145452eebe55 Ezequiel Garcia   2019-07-11  1774  static int std_validate_compound(const struct v4l2_ctrl *ctrl, u32 idx,
0176077a813933a Hans Verkuil      2014-04-27  1775  				 union v4l2_ctrl_ptr ptr)
0176077a813933a Hans Verkuil      2014-04-27  1776  {
0e380411d9f043f Ezequiel Garcia   2020-11-05  1777  	struct v4l2_ctrl_mpeg2_sequence *p_mpeg2_sequence;
0e380411d9f043f Ezequiel Garcia   2020-11-05  1778  	struct v4l2_ctrl_mpeg2_picture *p_mpeg2_picture;
c27bb30e7b6d385 Paul Kocialkowski 2018-09-13  1779  	struct v4l2_ctrl_mpeg2_slice_params *p_mpeg2_slice_params;
298c62d3856111e Ezequiel Garcia   2019-07-11  1780  	struct v4l2_ctrl_vp8_frame_header *p_vp8_frame_header;
d9358563179a7f0 Ezequiel Garcia   2020-08-25  1781  	struct v4l2_ctrl_h264_slice_params *p_h264_slice_params;
f9879eb378295e8 Ezequiel Garcia   2020-08-25  1782  	struct v4l2_ctrl_h264_decode_params *p_h264_dec_params;
256fa3920874b0f Paul Kocialkowski 2019-10-22  1783  	struct v4l2_ctrl_hevc_sps *p_hevc_sps;
256fa3920874b0f Paul Kocialkowski 2019-10-22  1784  	struct v4l2_ctrl_hevc_pps *p_hevc_pps;
256fa3920874b0f Paul Kocialkowski 2019-10-22  1785  	struct v4l2_ctrl_hevc_slice_params *p_hevc_slice_params;
d1dc49370f8371b Ricardo Ribalda   2019-10-07  1786  	struct v4l2_area *area;
de8145452eebe55 Ezequiel Garcia   2019-07-11  1787  	void *p = ptr.p + idx * ctrl->elem_size;
256fa3920874b0f Paul Kocialkowski 2019-10-22  1788  	unsigned int i;
de8145452eebe55 Ezequiel Garcia   2019-07-11  1789  
de8145452eebe55 Ezequiel Garcia   2019-07-11  1790  	switch ((u32)ctrl->type) {
0e380411d9f043f Ezequiel Garcia   2020-11-05  1791  	case V4L2_CTRL_TYPE_MPEG2_SEQUENCE:
0e380411d9f043f Ezequiel Garcia   2020-11-05  1792  		p_mpeg2_sequence = p;
de8145452eebe55 Ezequiel Garcia   2019-07-11  1793  
0e380411d9f043f Ezequiel Garcia   2020-11-05  1794  		switch (p_mpeg2_sequence->chroma_format) {
de8145452eebe55 Ezequiel Garcia   2019-07-11  1795  		case 1: /* 4:2:0 */
de8145452eebe55 Ezequiel Garcia   2019-07-11  1796  		case 2: /* 4:2:2 */
de8145452eebe55 Ezequiel Garcia   2019-07-11  1797  		case 3: /* 4:4:4 */
de8145452eebe55 Ezequiel Garcia   2019-07-11  1798  			break;
de8145452eebe55 Ezequiel Garcia   2019-07-11  1799  		default:
de8145452eebe55 Ezequiel Garcia   2019-07-11  1800  			return -EINVAL;
de8145452eebe55 Ezequiel Garcia   2019-07-11  1801  		}
0e380411d9f043f Ezequiel Garcia   2020-11-05  1802  		zero_reserved(*p_mpeg2_sequence);
0e380411d9f043f Ezequiel Garcia   2020-11-05  1803  		break;
0e380411d9f043f Ezequiel Garcia   2020-11-05  1804  
0e380411d9f043f Ezequiel Garcia   2020-11-05  1805  	case V4L2_CTRL_TYPE_MPEG2_PICTURE:
0e380411d9f043f Ezequiel Garcia   2020-11-05  1806  		p_mpeg2_picture = p;
0e380411d9f043f Ezequiel Garcia   2020-11-05  1807  		break;
                                                                ^^^^^^

de8145452eebe55 Ezequiel Garcia   2019-07-11  1808  
0e380411d9f043f Ezequiel Garcia   2020-11-05 @1809  		switch (p_mpeg2_picture->intra_dc_precision) {
                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unreachable.

de8145452eebe55 Ezequiel Garcia   2019-07-11  1810  		case 0: /* 8 bits */
de8145452eebe55 Ezequiel Garcia   2019-07-11  1811  		case 1: /* 9 bits */
de8145452eebe55 Ezequiel Garcia   2019-07-11  1812  		case 2: /* 10 bits */
de8145452eebe55 Ezequiel Garcia   2019-07-11  1813  		case 3: /* 11 bits */
de8145452eebe55 Ezequiel Garcia   2019-07-11  1814  			break;
de8145452eebe55 Ezequiel Garcia   2019-07-11  1815  		default:
de8145452eebe55 Ezequiel Garcia   2019-07-11  1816  			return -EINVAL;
de8145452eebe55 Ezequiel Garcia   2019-07-11  1817  		}
0e380411d9f043f Ezequiel Garcia   2020-11-05  1818  		break;
de8145452eebe55 Ezequiel Garcia   2019-07-11  1819  


Download attachment ".config.gz" of type "application/gzip" (31910 bytes)