linux-kernel - Re: [PATCH v2 02/13] ARM: dts: mmp2-olpc-xo-1-75: Delete #address-cells from ssp3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a98683e3-c666-a308-9c67-b898134c13fe@gmail.com>
Date:   Mon, 9 Nov 2020 19:19:30 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Lubomir Rintel <lkundrak@...sk>, Arnd Bergmann <arnd@...db.de>,
        Olof Johansson <olof@...om.net>,
        Rob Herring <robh+dt@...nel.org>
Cc:     SoC Team <soc@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/13] ARM: dts: mmp2-olpc-xo-1-75: Delete
 #address-cells from ssp3



On 7/18/2020 1:50 PM, Lubomir Rintel wrote:
> On the XO-1.75, this node represents a bus interface that operates in slave
> mode and thus is only able to accommodate a single subnode; no address
> cells are necessary.
> 
> The Documentation/devicetree/bindings/spi/spi-controller.yaml binding
> prefers that we drop the property instead of setting it to zero.
> 
> This fixes a DT validation error:
> 
>   arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: spi@...37000:
>       { ... } is valid under each of {'required': ['spi-slave']},
>                                      {'required': ['#address-cells']}
> 
> We also need to drop #size-cells:
> 
>   arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: spi@...37000:
>       '#address-cells' is a dependency of '#size-cells'
> 
> Signed-off-by: Lubomir Rintel <lkundrak@...sk>

This patch causes the following warning to be issued when validating the
mmp2 DTS files against specific bindings:

arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge):
/soc/apb@...00000/spi@...37000: incorrect #address-cells for SPI bus
  also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3
arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge):
/soc/apb@...00000/spi@...37000: incorrect #size-cells for SPI bus
  also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3
arch/arm/boot/dts/mmp2-olpc-xo-1-75.dt.yaml: Warning (spi_bus_reg):
Failed prerequisite 'spi_bus_bridge'

Is there a fix that we can apply to silence this warning? Thanks!
-- 
Florian