linux-kernel - Re: [PATCH 1/2] jffs2: fix ignoring mounting options problem during remounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvwO_i31AF350i+9w-7wg25NToyVFFBcG2oHXW3m9sS+MQ@mail.gmail.com>
Date:   Tue, 10 Nov 2020 22:34:17 +0100
From:   Richard Weinberger <richard.weinberger@...il.com>
To:     Zhe Li <lizhe67@...wei.com>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Richard Weinberger <richard@....at>, wangfangpeng1@...wei.com,
        zhongjubin@...wei.com, LKML <linux-kernel@...r.kernel.org>,
        linux-mtd@...ts.infradead.org, qiuxi1@...wei.com,
        chenjie6@...wei.com
Subject: Re: [PATCH 1/2] jffs2: fix ignoring mounting options problem during remounting

On Wed, Oct 14, 2020 at 9:01 AM Zhe Li <lizhe67@...wei.com> wrote:
>
> From: lizhe <lizhe67@...wei.com>
>
> The jffs2 mount options will be ignored when remounting jffs2.
> It can be easily reproduced with the steps listed below.
> 1. mount -t jffs2 -o compr=none /dev/mtdblockx /mnt
> 2. mount -o remount compr=zlib /mnt
>
> Since ec10a24f10c8, the option parsing happens before fill_super and
> then pass fc, which contains the options parsing results, to function
> jffs2_reconfigure during remounting. But function jffs2_reconfigure do
> not update c->mount_opts.
>
> This patch add a function jffs2_update_mount_opts to fix this problem.

Oh, a regression. Thanks for fixing.

> By the way, I notice that tmpfs use the same way to update remounting
> options. If it is necessary to unify them?

If possible, sure. Maybe you can find a way to put the logic into fs/libfs.c

-- 
Thanks,
//richard