linux-kernel - Re: [PATCH] selftests/seccomp: Update kernel config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d4723ea9-d561-fc0c-c4c5-24c6fd454064@linuxfoundation.org>
Date:   Tue, 10 Nov 2020 14:36:56 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Mickaël Salaün <mic@...ikod.net>,
        Kees Cook <keescook@...omium.org>,
        Shuah Khan <shuah@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        Tycho Andersen <tycho@...ho.pizza>,
        Mickaël Salaün <mic@...ux.microsoft.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/seccomp: Update kernel config

On 10/30/20 6:18 AM, Mickaël Salaün wrote:
> seccomp_bpf.c uses unshare(CLONE_NEWPID), which requires CONFIG_PID_NS
> to be set.
> 
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: Tycho Andersen <tycho@...ho.pizza>
> Fixes: 6a21cc50f0c7 ("seccomp: add a return code to trap to userspace")
> Signed-off-by: Mickaël Salaün <mic@...ux.microsoft.com>
> ---
>   tools/testing/selftests/seccomp/config | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/seccomp/config b/tools/testing/selftests/seccomp/config
> index 64c19d8eba79..ad431a5178fb 100644
> --- a/tools/testing/selftests/seccomp/config
> +++ b/tools/testing/selftests/seccomp/config
> @@ -1,3 +1,4 @@
> +CONFIG_PID_NS=y
>   CONFIG_SECCOMP=y
>   CONFIG_SECCOMP_FILTER=y
>   CONFIG_USER_NS=y
> 
> base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec
> 

Your from and Signed-off-by don't match. Please send the patch
from your igned-off-by address.

WARNING: From:/Signed-off-by: email address mismatch: 'From: "Mickaël 
Salaün" <mic@...ikod.net>' != 'Signed-off-by: Mickaël Salaün 
<mic@...ux.microsoft.com>'

thanks,
-- Shuah