linux-kernel - Re: [PATCH 11/20] drm/radeon/r600: Strip out set but unused 'tmp' variables

Open Source and information security mailing list archives

Date:   Tue, 10 Nov 2020 17:17:13 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     David Airlie <airlied@...ux.ie>,
        LKML <linux-kernel@...r.kernel.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Christian König <christian.koenig@....com>,
        "moderated list:DMA BUFFER SHARING FRAMEWORK" 
        <linaro-mm-sig@...ts.linaro.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Alex Deucher <alexander.deucher@....com>,
        linux-media <linux-media@...r.kernel.org>
Subject: Re: [PATCH 11/20] drm/radeon/r600: Strip out set but unused 'tmp' variables

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/radeon/r600.c: In function ‘r600_pcie_gart_tlb_flush’:
>  drivers/gpu/drm/radeon/r600.c:1083:7: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]
>  drivers/gpu/drm/radeon/r600.c: At top level:
>  drivers/gpu/drm/radeon/r600.c: In function ‘r600_mmio_hdp_flush’:
>  drivers/gpu/drm/radeon/r600.c:4393:7: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]
>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: "Christian König" <christian.koenig@....com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Sumit Semwal <sumit.semwal@...aro.org>
> Cc: amd-gfx@...ts.freedesktop.org
> Cc: dri-devel@...ts.freedesktop.org
> Cc: linux-media@...r.kernel.org
> Cc: linaro-mm-sig@...ts.linaro.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/r600.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c
> index d9a33ca768f34..6e780b0109995 100644
> --- a/drivers/gpu/drm/radeon/r600.c
> +++ b/drivers/gpu/drm/radeon/r600.c
> @@ -1080,7 +1080,6 @@ void r600_pcie_gart_tlb_flush(struct radeon_device *rdev)
>         if ((rdev->family >= CHIP_RV770) && (rdev->family <= CHIP_RV740) &&
>             !(rdev->flags & RADEON_IS_AGP)) {
>                 void __iomem *ptr = (void *)rdev->gart.ptr;
> -               u32 tmp;
>
>                 /* r7xx hw bug.  write to HDP_DEBUG1 followed by fb read
>                  * rather than write to HDP_REG_COHERENCY_FLUSH_CNTL
> @@ -1088,7 +1087,7 @@ void r600_pcie_gart_tlb_flush(struct radeon_device *rdev)
>                  * method for them.
>                  */
>                 WREG32(HDP_DEBUG1, 0);
> -               tmp = readl((void __iomem *)ptr);
> +               readl((void __iomem *)ptr);
>         } else
>                 WREG32(R_005480_HDP_MEM_COHERENCY_FLUSH_CNTL, 0x1);
>
> @@ -4390,10 +4389,9 @@ void r600_mmio_hdp_flush(struct radeon_device *rdev)
>         if ((rdev->family >= CHIP_RV770) && (rdev->family <= CHIP_RV740) &&
>             rdev->vram_scratch.ptr && !(rdev->flags & RADEON_IS_AGP)) {
>                 void __iomem *ptr = (void *)rdev->vram_scratch.ptr;
> -               u32 tmp;
>
>                 WREG32(HDP_DEBUG1, 0);
> -               tmp = readl((void __iomem *)ptr);
> +               readl((void __iomem *)ptr);
>         } else
>                 WREG32(R_005480_HDP_MEM_COHERENCY_FLUSH_CNTL, 0x1);
>  }
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives