linux-kernel - Re: [PATCH v2] pinctrl: qcom: Fix msm8953 Kconfig entry to depend on, not select PINCTRL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201110231101.GG807@yoga>
Date:   Tue, 10 Nov 2020 17:11:01 -0600
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     John Stultz <john.stultz@...aro.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Andy Gross <agross@...nel.org>,
        Prasad Sodagudi <psodagud@...eaurora.org>,
        Vladimir Lypak <junak.pub@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v2] pinctrl: qcom: Fix msm8953 Kconfig entry to depend
 on, not select PINCTRL_MSM

On Tue 10 Nov 15:56 CST 2020, John Stultz wrote:

> One fixup following my patch commit be117ca32261 ("pinctrl:
> qcom: Kconfig: Rework PINCTRL_MSM to be a depenency rather then
> a selected config") being queued in LinusW's tree, as a new
> config entry was added for the msm8953 that also needs the
> change.
> 
> Applies to LinusW's pinctrl devel tree.
> 
> Cc: Andy Gross <agross@...nel.org>
> Cc: Prasad Sodagudi <psodagud@...eaurora.org>
> Cc: Vladimir Lypak <junak.pub@...il.com>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: linux-arm-msm@...r.kernel.org
> Cc: linux-gpio@...r.kernel.org
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> Change-Id: I9e8e83b1ea57aff338074be9174fce53cef29eff

Linus, please drop the change-id as you apply this.

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
> v2:
> * Fix flipped numbers in the soc name, pointed out by
>   Jeffrey Hugo
> ---
>  drivers/pinctrl/qcom/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
> index 8bdf878fe970c..cf56e029cd9c7 100644
> --- a/drivers/pinctrl/qcom/Kconfig
> +++ b/drivers/pinctrl/qcom/Kconfig
> @@ -115,7 +115,7 @@ config PINCTRL_MSM8916
>  config PINCTRL_MSM8953
>  	tristate "Qualcomm 8953 pin controller driver"
>  	depends on GPIOLIB && OF
> -	select PINCTRL_MSM
> +	depends on PINCTRL_MSM
>  	help
>  	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
>  	  Qualcomm TLMM block found on the Qualcomm MSM8953 platform.
> -- 
> 2.17.1
>