linux-kernel - Re: [PATCH] fs/ntfs: remove unused varible attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5814AA20-1544-4563-9244-BD40C37AB1D9@tuxera.com>
Date:   Tue, 10 Nov 2020 00:52:13 +0000
From:   Anton Altaparmakov <anton@...era.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
CC:     "linux-ntfs-dev@...ts.sourceforge.net" 
        <linux-ntfs-dev@...ts.sourceforge.net>,
        LKML <linux-kernel@...r.kernel.org>,
        Alex Shi <alex.shi@...ux.alibaba.com>
Subject: Re: [PATCH] fs/ntfs: remove unused varible attr_len

Hi Andrew,

Can you also please merge this one?  Thanks a lot in advance!

Alex, again, thank you for the patch!

Best regards,

	Anton

> On 8 Nov 2020, at 08:06, Alex Shi <alex.shi@...ux.alibaba.com> wrote:
> From: Alex Shi <alex.shi@...ux.alibaba.com>
> Date: Sun, 8 Nov 2020 15:52:32 +0800
> Subject: [PATCH] fs/ntfs: remove unused varible attr_len
> 
> This varible isn't used anymore, remove it to skip W=1 warning:
> fs/ntfs/inode.c:2350:6: warning: variable ‘attr_len’ set but not used
> [-Wunused-but-set-variable]
> 
> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Acked-by: Anton Altaparmakov <anton@...era.com>
> ---
> fs/ntfs/inode.c | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ntfs/inode.c b/fs/ntfs/inode.c
> index caf563981532..f7e4cbc26eaf 100644
> --- a/fs/ntfs/inode.c
> +++ b/fs/ntfs/inode.c
> @@ -2347,7 +2347,6 @@ int ntfs_truncate(struct inode *vi)
> 	ATTR_RECORD *a;
> 	const char *te = "  Leaving file length out of sync with i_size.";
> 	int err, mp_size, size_change, alloc_change;
> -	u32 attr_len;
> 
> 	ntfs_debug("Entering for inode 0x%lx.", vi->i_ino);
> 	BUG_ON(NInoAttr(ni));
> @@ -2721,7 +2720,6 @@ int ntfs_truncate(struct inode *vi)
> 	 * this cannot fail since we are making the attribute smaller thus by
> 	 * definition there is enough space to do so.
> 	 */
> -	attr_len = le32_to_cpu(a->length);
> 	err = ntfs_attr_record_resize(m, a, mp_size +
> 			le16_to_cpu(a->data.non_resident.mapping_pairs_offset));
> 	BUG_ON(err);
> -- 
> 1.8.3.1
> 


-- 
Anton Altaparmakov <anton at tuxera.com> (replace at with @)
Lead in File System Development, Tuxera Inc., http://www.tuxera.com/
Linux NTFS maintainer