linux-kernel - Re: [PATCH v2 net-next] net: skb_vlan_untag(): don't reset transport offset if set by GRO layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Nov 2020 04:20:04 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Alexander Lobakin <alobakin@...me>
Cc:     davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
        linmiaohe@...wei.com, martin.varghese@...ia.com, pshelar@....org,
        willemb@...gle.com, gnault@...hat.com, viro@...iv.linux.org.uk,
        fw@...len.de, steffen.klassert@...unet.com, pabeni@...hat.com,
        kyk.segfault@...il.com, vladimir.oltean@....com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: skb_vlan_untag(): don't reset transport
 offset if set by GRO layer

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 09 Nov 2020 23:47:23 +0000 you wrote:
> Similar to commit fda55eca5a33f
> ("net: introduce skb_transport_header_was_set()"), avoid resetting
> transport offsets that were already set by GRO layer. This not only
> mirrors the behavior of __netif_receive_skb_core(), but also makes
> sense when it comes to UDP GSO fraglists forwarding: transport offset
> of such skbs is set only once by GRO receive callback and remains
> untouched and correct up to the xmitting driver in 1:1 case, but
> becomes junk after untagging in ingress VLAN case and breaks UDP
> GSO offload. This does not happen after this change, and all types
> of forwarding of UDP GSO fraglists work as expected.
> 
> [...]

Here is the summary with links:
  - [v2,net-next] net: skb_vlan_untag(): don't reset transport offset if set by GRO layer
    https://git.kernel.org/netdev/net-next/c/8be33ecfc1ff

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html